Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the types path in package.json #82

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Fix the types path in package.json #82

merged 1 commit into from
Sep 21, 2024

Conversation

notatestuser
Copy link
Contributor

What's new

The types field in package.json is pointing to the wrong place. This change fixes it.

The built lib directory in fact looks like this. This is also true for the npm package.

image

Resolved issues

  • The types are resolved properly by the TS compiler.

@notatestuser
Fix the types path in package.json
a69f7a2 
The `types` field in package.json is pointing to the wrong place. This commit fixes it.
@tompsota
Copy link
Member

Hi @notatestuser,

Thanks for the PR! Indeed, the types are pointing to an incorrect location. We'll be adding this to the next release.

Regards,
Tomas from Talsec

@tompsota tompsota merged commit dd34f08 into talsec:master Sep 21, 2024
@notatestuser
Copy link
Contributor Author

Thanks @tompsota! Could we get an npm package publish?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notatestuser @tompsota